Repository navigation
Test: Gate the Linux parity runs on the resize rows (core-extended #139) - #253
Merged
Merged
Conversation
…etail log Pins the fork at its instrumented branch (core-extended #139) and turns the detail log on in the Linux parity run. Not for merging as it stands: it proves the cause first.
The instrumented branch of the fork sits on the newest extended, which also moves the published coordinates; the probe measures the code #251 ships, so the instrumentation is cherry-picked onto 1b3de18f.
… feat/x11-stale-present
…sent # Conflicts: # renderer/scripts/build-compose.sh
…R-3) The newest extended, with core-extended #140 (a scripted drag asks for the next size only once the last is confirmed and drawn) and #141 (both X11 windows resized through openbox and its sync counter, stale 0 and stretched 0). The Linux parity runs gate on resize_stale_ratio and resize_stretched on both paths, and keep the resize detail log for the artifacts.
b-re-w
marked this pull request as ready for review
October 18, 2026 02:34
Since core-extended #138 both GraalVM window modules name ../../scene (compile-only, for the window surfaces runComposeWindow uses), and the project publish-window.sh writes listed neither, so the toolchain could not read the project ("Cannot find module file in //scene") and every renderer build on a pin past #138 stopped there. scene is listed now, and built for the JVM alone off macOS, since its other platform is macosArm64.
…k's desktop Compose
scene compiles against the fork's Compose for the desktop, which a Kotlin/Native build (the
static Linux renderer, the Linux renderer tests) does not publish, so resolving it failed
there ("runtime-desktop:1.11.1-ext.1 ... problem"). Those builds need neither scene nor the
GraalVM window modules; they are published where the desktop Compose is, which every build
of the renderer's desktop module has.
The GraalVM macOS renderer build has the fork's desktop Compose but not its Compose for macosArm64, and scene's macosArm64 half failed to resolve there. Nothing this renderer builds uses that half, so scene is published for the JVM alone everywhere, edited with a sed that both GNU and BSD take.
…sent # Conflicts: # renderer/scripts/build-compose.sh
…cies - GitHub Releases recently deployed a Content-Security-Policy header exceeding 8192 characters, which triggers Ktor's TooLongLineException when Amper downloads Adoptium JDK or pnpm releases. Prefetching those archives directly with curl into Amper's download.cache avoids Ktor contacting GitHub Releases. - publish-window.sh compiles common for jvm alone when no native modules are requested, avoiding unnecessary native klib compilation. - Remove apostrophes inside the inline perl script in fork-dependencies.sh to prevent bash syntax errors.
- Restrict common window module platforms to host-supported targets (Darwin: jvm and macosArm64; Linux: jvm and linux targets; Windows: jvm) so native targets find common dependencies without triggering cross-OS distribution commonization.
…k test - In-place patch Ktor HTTP client's 8192-character header limit in the extracted toolchain jar to prevent TooLongLineException when downloading assets from GitHub Releases. - Update setup_check_reports_missing_nik test expectation to 0 matching its warning behavior, and preserve RUSTUP_HOME and CARGO_HOME on macOS.
…ow platforms - In prefetch-github-assets.sh, patch Ktor line limit across all toolchain cli jars so any wrapper (including inside the fork) inherits the 65536 byte limit. - In publish-window.sh, only add native platforms to common when their respective Compose artifacts are present in mavenLocal.
- Run renderer/kotlin --version in publish-window.sh before entering the fork directory so the toolchain is provisioned and Ktor header limits patched before the fork wrapper runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes nothing here; finishes thisisthepy/compose-multiplatform-core-extended#139.
Measured on the fix (GraalVM X11 parity in this PR's earlier run): steps 60, presented 130, stale 0, stretched 0, stale_ratio 0.0000.